Fixed isJansiConsoleInstalled performance issue #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isJansiConsoleInstalled() was repeatedly called in a loop from the TextTable#toString method, which caused performance problems due to the constant calls to Class#forName. This change caches the result from isJansiConsoleInstalled so it doesn't repeatedly call Class#forName, which cannot change at runtime.
remkop
added
type: enhancement ✨
theme: usagehelp
remkop
previously approved these changes
Mar 20, 2023
|
@ChrisTrenkamp I had to enable CI/CD for this PR, but now I see some tests are failing: and This may be due to the order in which tests are executed. |
Fixed unit test by resetting the cached isJansiConsoleInstalled result.
ModelTransformerTest#testUsage
|
The failing test cases are passing now, but it had to be done by resetting the cached value. Doesn't feel like the most elegant way to handle this. |
|
I see what you mean but I cannot think of an alternative either. 😅 |
remkop
approved these changes
Mar 21, 2023
|
Having some trouble with the CI/CD, but I do see this failing test: |
remkop
added a commit
that referenced
this pull request
Mar 24, 2023
|
Merged. Sorry, it took some time to sort out the CI/CD issues. |
remkop
added a commit
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1975
isJansiConsoleInstalled() was repeatedly called
in a loop from the TextTable#toString method,
which caused performance problems due to the
constant calls to Class#forName. This change
caches the result from isJansiConsoleInstalled so
it doesn't repeatedly call Class#forName, which
cannot change at runtime.